回覆: [PATCH net-next v3 3/7] net: ftgmac100: Add reset toggling for Aspeed SOCs

From: Jacky Chou
Date: Tue Nov 26 2024 - 22:48:23 EST


Hi Philipp,

Thank you for your reply.

> > + priv->rst = devm_reset_control_get_optional_exclusive(priv->dev, NULL);
> > + if (IS_ERR(priv->rst))
> > + goto err_register_netdev;
> > + if (!priv->rst)
> > + dev_info(&pdev->dev, "no reset control found\n");
>
> Am I understanding correctly that the aspeed-g4 to g6 platforms don't have the
> reset? If so, this message is unnecessary noise on those platforms.

Agree. There is no reset property for aspeed-g4 to g6 platforms.
Indeed, even if the reset does not exist, there is no need to display the message.
I will remove the message in next version.

Thanks,
Jacky