回覆: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700

From: Jacky Chou
Date: Tue Nov 26 2024 - 22:57:20 EST


Hi Krzysztof,

Thank you for your reply.

> >> diff --git
> >> a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> index 9bcbacb6640d..fffe5c51daa9 100644
> >> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> @@ -21,6 +21,7 @@ properties:
> >> - aspeed,ast2400-mac
> >> - aspeed,ast2500-mac
> >> - aspeed,ast2600-mac
> >> + - aspeed,ast2700-mac
> >> - const: faraday,ftgmac100
> >>
> >> reg:
> >> @@ -33,7 +34,7 @@ properties:
> >> minItems: 1
> >> items:
> >> - description: MAC IP clock
> >> - - description: RMII RCLK gate for AST2500/2600
> >> + - description: RMII RCLK gate for AST2500/2600/2700
> >>
> >> clock-names:
> >> minItems: 1
> >
> > Given patch 3, I would expect a resets property to be defined and
> > possibly added to the list of required properties for aspeed,ast2700-
> > mac.
>
>
> Yeah, DTS was not tested at all.
>
> Jacky, where is the DTS, so we can validate it? Please provide link in cover
> letter.
>

About the DTS of Aspeed g7, we have verified on our SDK and g7 platform.
Please refer to these links on our github.
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v6.6/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v6.6/arch/arm64/boot/dts/aspeed/ast2700-evb.dts

We are preparing to submit these DTS to mainline.

Thanks,
Jacky