Re: [PATCH v3 2/3] arm64: dts: nuvoton: Add Ethernet nodes

[Joey Lu]

Dear Krzysztof,

Thank you for your reply.

Krzysztof Kozlowski 於 11/26/2024 6:08 PM 寫道:
> On 18/11/2024 09:27, Joey Lu wrote:
> > diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
> > index e51b98f5bdce..2e0071329309 100644
> > --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
> > +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
> > @@ -379,5 +379,57 @@ uart16: serial@40880000 {
> >   			clocks = <&clk UART16_GATE>;
> >   			status = "disabled";
> >   		};
> > +
> > +		gmac0: ethernet@40120000 {
> > +			compatible = "nuvoton,ma35d1-dwmac";
> > +			reg = <0x0 0x40120000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-names = "macirq";
> > +			clocks = <&clk EMAC0_GATE>, <&clk EPLL_DIV8>;
> > +			clock-names = "stmmaceth", "ptp_ref";
> > +
> > +			nuvoton,sys = <&sys 0>;
> > +			resets = <&sys MA35D1_RESET_GMAC0>;
> > +			reset-names = "stmmaceth";
> > +			status = "disabled";
> Status is always, always the last property. Please read and follow DTS
> coding style.
>
> Best regards,
> Krzysztof

Got it. I will fix these.

Thanks!

BR,

Joey