Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add USB SuperSpeed support

[s-vadapalli]

On Tue, Nov 26, 2024 at 11:08:19AM +0100, Enric Balletbo i Serra wrote:

Hello Enric,

> From: Dasnavis Sabiya <sabiya.d@xxxxxx>
> 
> AM69 SK board has two stacked USB3 connectors:
>    1. USB3 (Stacked TypeA + TypeC)
>    2. USB3 TypeA Hub interfaced through TUSB8041.
> 
> The board uses SERDES0 Lane 3 for USB3 IP. So update the
> SerDes lane info for PCIe and USB. Add the pin mux data
> and enable USB 3.0 support with its respective SERDES settings.
> 
> Signed-off-by: Dasnavis Sabiya <sabiya.d@xxxxxx>
> Signed-off-by: Enric Balletbo i Serra <eballetb@xxxxxxxxxx>
> ---
> I've been carrying this patch for quite long time in my builds to have
> support for USB on my AM69-SK board without problems. For some reason this
> patch was never send to upstream or I couldn't find it. So I took the
> opportunity, now that I rebased my build, to send upstream.
> 
> I have maintained the original author of the downstream patch as is
> basically his work.
> ---
>  arch/arm64/boot/dts/ti/k3-am69-sk.dts | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts

[...]

> +&usb0 {
> +	status = "okay";
> +	dr_mode = "host";

Since the Type-C interface is also connected to USB0, shouldn't "dr_mode"
be "otg"? Also, has the Type-C interface been tested with this patch?
Please let me know.

[...]

Regards,
Siddharth.