Re: [PATCH 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens

From: Krzysztof Kozlowski
Date: Wed Nov 27 2024 - 05:26:02 EST


On 27/11/2024 11:22, Dmitry Torokhov wrote:
> On November 27, 2024 2:19:38 AM PST, Sasha Finkelstein <fnkl.kernel@xxxxxxxxx> wrote:
>> On Wed, 27 Nov 2024 at 10:00, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>>> + dev_err(dev, "unable to get reset");
>>>
>>> Syntax is: return dev_err_probe, almost everywhere here.
>>
>> Per discussion on previous version of this series, input asks
>> dev_err_probe to not be used.
>
> They twisted my arm. It's ok to use now.

I am fine if that's the preference for input, although this particular
case without dev_err_probe would be just wrong: possible dmesg flood on
deferral.

Best regards,
Krzysztof