Re: [cocci] [PATCH 01/11] coccinelle: Add script to reorder capable() calls

From: Markus Elfring
Date: Wed Nov 27 2024 - 06:46:10 EST



> +++ b/scripts/coccinelle/api/capable_order.cocci

> +@ depends on patch@
> +identifier F = { capable, ns_capable, sockopt_ns_capable };
> +binary operator op,op1,op2;

> +- F@p(EL) op E
> ++ E op F(EL)



You would like to reorder expression parts.
How do you think about to increase the precision for such
an SmPL change specification?

* May only operators be taken into account for which
the commutative property holds?

* Would you like to support a varying length for the affected
operator chain (≥ 2 operands)?


Regards,
Markus