Re: wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe()
From: Markus Elfring
Date: Wed Nov 27 2024 - 07:40:53 EST
>> Is there a need to reconsider also such a return value?
>
> According to the current code (commit d5c65159f289) of
> this function, this function should be terminated directly
> after checking the null pointer, the return value may be
> meaningless.
The return value is checked at two source code places at least.
* ath11k_ce_recv_process_cb():
https://elixir.bootlin.com/linux/v6.12.1/source/drivers/net/wireless/ath/ath11k/ce.c#L450
* ath11k_ce_rx_post_buf():
https://elixir.bootlin.com/linux/v6.12.1/source/drivers/net/wireless/ath/ath11k/ce.c#L893
May the detection of a null pointer for the data structure members
“dest_ring” or “status_ring” really be interpreted as a successful execution
of the function “ath11k_ce_rx_post_pipe”?
Regards,
Markus