Re: [PATCH v2] clk: renesas: cpg-mssr: fix 'soc' node handling in cpg_mssr_reserved_init()

[Geert Uytterhoeven]

On Thu, Oct 31, 2024 at 1:43 PM Javier Carrasco
<javier.carrasco.cruz@xxxxxxxxx> wrote:
> A device_node reference obtained via of_find_node_by_path() requires
> explicit calls to of_node_put() after it is no longer required to avoid
> leaking the resource.
>
> Instead of adding the missing calls to of_node_put() in all execution
> paths, use the cleanup attribute for 'soc' by means of the __free()
> macro, which automatically calls of_node_put() when the variable goes
> out of scope.
>
> Fixes: 6aa175476490 ("clk: renesas: cpg-mssr: Ignore all clocks assigned to non-Linux system")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
> Changes in v2:
> - Squash patches for mainline solution without intermediate steps.
> - Link to v1: https://lore.kernel.org/r/20241031-clk-renesas-cpg-mssr-cleanup-v1-0-628274ecbfcb@xxxxxxxxx

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-clk for v6.14.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds