Re: [PATCH] arm64: kexec: Check if IRQ is already masked before masking

From: Farber, Eliav
Date: Wed Nov 27 2024 - 09:59:09 EST


Maybe a slightly better approach would be to simplify this code for
something that actually uses the kernel infrastructure:

diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index 82e2203d86a31..9b48d952df3ec 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -230,11 +230,8 @@ static void machine_kexec_mask_interrupts(void)
chip->irq_eoi)
chip->irq_eoi(&desc->irq_data);

- if (chip->irq_mask)
- chip->irq_mask(&desc->irq_data);
-
- if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
- chip->irq_disable(&desc->irq_data);
+ irq_set_status_flags(i, IRQ_DISABLE_UNLAZY);
+ irq_disable(desc);
}
}

This is of course untested.

I tested your suggested approach and it works.
I will upload V2 for this change.

Thanks, Eliav