Aw: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
From: Frank Wunderlich
Date: Wed Nov 27 2024 - 10:29:24 EST
> Gesendet: Mittwoch, 27. November 2024 um 14:34
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>
> An: "Frank Wunderlich" <linux@xxxxxxxxx>, "Rob Herring" <robh@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzk+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>
> CC: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Betreff: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
>
> Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >
> > Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> Please add the lvts_calibration nvmem entry in this commit instead.
and leaving the other (currently not linked) subnodes?
> Cheers,
> Angelo
>
> > ---
> > arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> > index ed8ce1e6f68b..de9a9ff2edd8 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> > @@ -4,6 +4,7 @@
> > #include <dt-bindings interrupt-controller="" arm-gic.h="">
> > #include <dt-bindings phy="" phy.h="">
> > #include <dt-bindings pinctrl="" mt65xx.h="">
> > +#include <dt-bindings reset="" mediatek,mt7988-resets.h="">
> >
> > / {
> > compatible = "mediatek,mt7988a";
> > @@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
> > compatible = "mediatek,mt7988-infracfg", "syscon";
> > reg = <0 0x10001000 0 0x1000>;
> > #clock-cells = <1>;
> > + #reset-cells = <1>;
> > };
> >
> > topckgen: clock-controller@1001b000 {
> > @@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
> > status = "disabled";
> > };
> >
> > + lvts: lvts@1100a000 {
> > + compatible = "mediatek,mt7988-lvts-ap";
> > + #thermal-sensor-cells = <1>;
> > + reg = <0 0x1100a000 0 0x1000>;
> > + clocks = <&infracfg CLK_INFRA_26M_THERM_SYSTEM>;
> > + interrupts = <gic_spi 138="" irq_type_level_high="">;
> > + resets = <&infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST>;
> > + nvmem-cells = <&lvts_calibration>;
> > + nvmem-cell-names = "lvts-calib-data-1";
> > + };
> > +
> > ssusb0: usb@11190000 {
> > compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
> > reg = <0 0x11190000 0 0x2e00>,
>
> </gic_spi></dt-bindings></dt-bindings></dt-bindings></dt-bindings></frank-w@xxxxxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></matthias.bgg@xxxxxxxxx></conor+dt@xxxxxxxxxx></krzk+dt@xxxxxxxxxx></robh@xxxxxxxxxx></linux@xxxxxxxxx></angelogioacchino.delregno@xxxxxxxxxxxxx>