Re: [PATCH 3/9] dt-bindings: phy: samsung,usb3-drd-phy: gs101: require Type-C properties

[Conor Dooley]

On Wed, Nov 27, 2024 at 04:24:08PM +0000, André Draszik wrote:
> Hi Conor,
> 
> On Wed, 2024-11-27 at 16:00 +0000, Conor Dooley wrote:
> > On Wed, Nov 27, 2024 at 10:58:13AM +0000, André Draszik wrote:
> > > The USB PHY on gs101 needs to be configured based on the orientation of
> > > the connector. For that the DTS needs a link between the phy's port and
> > > a TCPCi, and we'll need to inform the phy driver that it should handle
> > > the orientation (register a handler).
> > > 
> > > Update the schema to enforce that by requiring the orientation-switch
> > > and port properties (on gs101 only).
> > > 
> > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> > 
> > What is your driver doing if these are not provided? New required
> > properties are an ABI break after all and I don't see a mention of how
> > you're handling it here.
> 
> This is hooked-in in patch 8 of this series in
> exynos5_usbdrd_setup_notifiers(). The new behaviour is gated off
> 
>     if (device_property_present(phy_drd->dev, "orientation-switch")) {
>         ...
> 
> Without that property (i.e. old DTS or !gs101), the driver will behave as
> before (meaning for gs101 it will work in SS mode in one orientation only).
> 
> Does that address your concern?

Aye, but it'd be good to call that out in your commit message.

Attachment: signature.asc
Description: PGP signature