Re: [PATCH] ntp: fix bug in adjtimex reading time offset
From: Thomas Gleixner
Date: Wed Nov 27 2024 - 12:35:29 EST
On Wed, Nov 27 2024 at 08:05, Richard Cochran wrote:
> On Wed, Nov 27, 2024 at 03:10:30PM +0100, Thomas Gleixner wrote:
> The patch was generated by the following coccinelle script:
>
> ...
>
> So I guess combining random other manual fixes into a patch that
> claims to be generated is a bad idea?
Indeed. I just figured out why the cast is there. txc::time_offset is of
type 'long long', so the division triggers a build fail on 32-bit.
It want's to be:
txc->time_offset = div_s64(txc->time_offset, NSEC_PER_USEC);
....