RE: [EXTERNAL] [PATCH] hv_netvsc: Set device flags for properly indicating bonding

From: Haiyang Zhang
Date: Wed Nov 27 2024 - 15:09:14 EST




> -----Original Message-----
> From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx>
> Sent: Wednesday, November 27, 2024 2:43 PM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Wei Liu <wei.liu@xxxxxxxxxx>; Dexuan Cui
> <decui@xxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Shradha Gupta
> <shradhagupta@xxxxxxxxxxxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>;
> Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>; Souradeep Chakrabarti
> <schakrabarti@xxxxxxxxxxxxxxxxxxx>; Erick Archer
> <erick.archer@xxxxxxxxxxx>; linux-hyperv@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx
> Cc: Long Li <longli@xxxxxxxxxxxxx>
> Subject: [EXTERNAL] [PATCH] hv_netvsc: Set device flags for properly
> indicating bonding
>
> From: Long Li <longli@xxxxxxxxxxxxx>
>
> hv_netvsc uses a subset of bonding features in that the master always
> has only one active slave. But it never properly setup those flags.
>
> Other kernel APIs (e.g those in "include/linux/netdevice.h") check for
> IFF_MASTER, IFF_SLAVE and IFF_BONDING for determing if those are used
> in a master/slave setup. RDMA uses those APIs extensively when looking
> for master/slave devices.
>
> Make hv_netvsc properly setup those flags.
>
> Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>

Please add Fixes tag, Cc stable, add "net" to the subject.
Thanks.
Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>