Re: [GIT PULL] Modules changes for v6.13-rc1

[Luis Chamberlain]

On Wed, Nov 27, 2024 at 01:22:37PM -0800, Linus Torvalds wrote:
> On Tue, 26 Nov 2024 at 17:10, Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
> >
> > Highlights for this merge window:
> 
> Lowlights:
> 
> >   * Adds a new modules selftests: kallsyms which helps us tests find_symbol()
> >     and the limits of kallsyms on Linux today.
> 
> This is completely broken.
> 
> Try doing "make allmodconfig" and then do "make" twice in a row.
> 
> It re-generates the tests, so you see this:
> 
>   GEN     lib/tests/module/test_kallsyms_a.c
>   GEN     lib/tests/module/test_kallsyms_b.c
>   GEN     lib/tests/module/test_kallsyms_c.c
>   GEN     lib/tests/module/test_kallsyms_d.c
>   CC [M]  lib/tests/module/test_kallsyms_a.o
>   CC [M]  lib/tests/module/test_kallsyms_b.o
>   CC [M]  lib/tests/module/test_kallsyms_c.o
>   CC [M]  lib/tests/module/test_kallsyms_d.o
>   LD [M]  lib/tests/module/test_kallsyms_a.ko
>   LD [M]  lib/tests/module/test_kallsyms_b.ko
>   LD [M]  lib/tests/module/test_kallsyms_c.ko
>   LD [M]  lib/tests/module/test_kallsyms_d.ko
> 
> both times, and this has made the empty build slow down by about a
> factor of two.
> 
> Which is a big deal, because the "empty build" is actually fairly
> important for me. It's the baseline build test performance, and with
> small pulls it actually dominates.
> 
> So this isn't ok. Please fix asap, because otherwise I will just
> revert it - it really does affect my workflow that much.

Sorry about that, I'm on it.

  Luis