Re: [PATCH] x86/aesni: fix uninit value for skcipher_walk

From: Eric Biggers
Date: Wed Nov 27 2024 - 18:55:26 EST


On Wed, Nov 27, 2024 at 03:43:47PM -0800, Ragavendra wrote:
> In crypto/aesni-intel_glue.c most declarations of struct
> skcipher_walk are unitialized. This causes one of the values
> in the struct to be left uninitialized in the later usages.
>
> This patch fixes it by adding initializations to the struct
> skcipher_walk walk variable.
>
> Fixes bugs reported in the Coverity scan with CID 139545,
> 1518179, 1585019 and 1598915.
>
> Signed-off-by: Ragavendra Nagraj <ragavendra.bn@xxxxxxxxx>

This should be fixed in skcipher_walk_virt(), not in every caller.

- Eric