Re: [PATCH v2 2/2] KVM: nVMX: Defer SVI update to vmcs01 on EOI when L2 is active w/o VID

From: Xiaoyao Li
Date: Wed Nov 27 2024 - 22:54:06 EST


On 11/28/2024 8:00 AM, Sean Christopherson wrote:
+void kvm_apic_update_hwapic_isr(struct kvm_vcpu *vcpu)
+{
+ struct kvm_lapic *apic = vcpu->arch.apic;
+
+ if (WARN_ON_ONCE(!lapic_in_kernel(vcpu)) || !apic->apicv_active)
+ return;
+
+ kvm_x86_call(hwapic_isr_update)(apic->vcpu, apic_find_highest_isr(apic));

Nit:

we have @vcpu already, no need to grab it from apic->vcpu.

+}
+EXPORT_SYMBOL_GPL(kvm_apic_update_hwapic_isr);