Re: [PATCH v2] dt-bindings: can: convert tcan4x5x.txt to DT schema

[Krzysztof Kozlowski]

On 06/11/2024 15:27, Krzysztof Kozlowski wrote:
> On 06/11/2024 15:24, Krzysztof Kozlowski wrote:
>> On Tue, Nov 05, 2024 at 03:24:34PM +0100, Sean Nyekjaer wrote:
>>> +  device-wake-gpios:
>>> +    description:
>>> +      Wake up GPIO to wake up the TCAN device.
>>> +      Not available with tcan4552/4553.
>>> +    maxItems: 1
>>> +
>>> +  bosch,mram-cfg:
>>
>> Last time I wrote:
>> "You need to mention all changes done to the binding in the commit msg."
>>
>> Then I wrote again:
>> "Yeah, CAREFULLY [read][//this was missing, added now] previous review
>> and respond to all comments or implement all of them (or any
>> combination). If you leave one comment ignored, it will mean reviewer
>> has to do same work twice. That's very discouraging and wasteful of my
>> time."
>>
>> Then I wrote:
>> "Where? I pointed out that this is a change. I cannot find it...."
>>
>> So we are back at the same spot but I waste much more time to respond
>> and repeat the same.
>>
>> You must address all comments: either respond, fix or ask for
>> clarifications. You cannot leave anything ignored.
>>
>> I am not going to review the rest.
> 
> Uh, I am wrong. You did remove the supplies, but I just looked at wrong
> version. Apologies, everything is fine and you did implement my
> feedback. Thank you.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

As pointed out recently, this is not correct conversion - it does not
match existing users. Conversion is supposed to lead to binding which
satisfies existing users - DTS and actual ABI - otherwise you produced
just incorrect schema.

Best regards,
Krzysztof