Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

From: Krzysztof Kozlowski
Date: Thu Nov 28 2024 - 05:09:24 EST


On 28/11/2024 10:22, Bhavin Sharma wrote:
>
>> Explaining what you asked:
>>
>> Some of these are from monitored-battery. Sense resistor should be
>> separate property. But different question is about missing resources,
>> like supplies (VCC) and interrupts. Just look at datasheet.
>
> since battery itself serves as the power supply for fuel gauge no additional supplies are required.
>
> Regarding interrupts yes, datasheet specifies an alarm pin that signals low State of Charge or
> Voltage conditions. However, I haven’t incorporated interrupts in the driver to handle this. Should I
> list the alarm pin as a resource in the device tree (or relevant configuration) even if it’s not
> implemented in the driver yet?

Yes, bindings should be complete.
Best regards,
Krzysztof