Re: [PATCH v3 2/3] clk: qcom: common: Add support for power-domain attachment

[Bryan O'Donoghue]

On 28/11/2024 12:07, Vladimir Zapolskiy wrote:
> Hello Bryan.
>
> On 11/27/24 01:44, Bryan O'Donoghue wrote:
> > Right now we support one power-domain per clock controller.
> > These single power-domains are switched on by the driver platform logic.
> >
> > However when we have multiple power-domains attached to a clock- 
> > controller
> > that list of power-domains must be handled outside of driver platform
> > logic.
> >
> > Use devm_pm_domain_attach_list() to automatically hook the list of given
> > power-domains in the dtsi for the clock-controller driver.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > ---
> >   drivers/clk/qcom/common.c | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
>
> Is there any particular reason why my review comment was ignored?
>
> https://lore.kernel.org/all/8a33c0ff-0c6d-4995- 
> b239-023d2a2c2af5@xxxxxxxxxx/
>
> There is no signs of the change improvement, unfortunately.
>
> --
> Best wishes,
> Vladimir

In the cover letter I cover what was done and not done and why.

I made a new function because it "looks neater" to me that way.

I implemented your feedback on ret and -EEXIST.

Passing NULL instead of &pd_data doesn't work unfortunately.

Let me know what else you'd like covered or revised from the cover letter.

---
bod