Re: [PATCH] selftest: hugetlb_dio: Fix test naming

[Donet Tom]

On 11/28/24 18:14, Mark Brown wrote:
> On Thu, Nov 28, 2024 at 10:46:56AM +0530, Donet Tom wrote:
> > On 11/27/24 21:44, Mark Brown wrote:
> > > +	ksft_test_result(free_hpage_a == free_hpage_b,
> > > +			 "free huge pages from %u-%u\n", start_off, end_off);
> > This test allocates a hugetlb buffer and adjusts the start and end offsets of the buffer based
> > on|start_off|  and|end_off|. The adjusted buffer is then used for Direct I/O (DIO). If I understand
> > correctly,|start_off|  and|end_off|  are not free huge pages but rather DIO buffer offsets. Should we
> > change this message to "Hugetlb DIO buffer offset"?
> Sure, so long as the message is consistent it doesn't really matter what
> it is from the point of view of the tooling.  I also noticed while doing
> this that the test doesn't verify that a huge page is actually used at
> any point, I was thinking about doing an incremental change for that
> too.

Sure. Thank you.

> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.