Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()

From: Max Kellermann
Date: Thu Nov 28 2024 - 08:12:15 EST


On Thu, Nov 28, 2024 at 1:49 PM Alex Markuze <amarkuze@xxxxxxxxxx> wrote:
> The ergonomics and error handling on this function seem awkward. I'll
> take a closer look on how to arrange it better.

Does that mean you misunderstood page ownership, or do you still
believe my patch is wrong?
To me, "pages must not be freed manually" and "pages must be freed
manually" can't both be right at the same time.