Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()

[Greg KH]

On Mon, Nov 25, 2024 at 09:29:46PM +0000, Al Viro wrote:
> On Mon, Nov 25, 2024 at 10:16:37PM +0100, Greg KH wrote:
> > On Mon, Nov 25, 2024 at 03:49:44PM +0800, Nanyong Sun wrote:
> > > Hi Greg,
> > >   Will this CVE be rejected in the future? This patch has introduced a
> > > problem and has been reverted:
> > > https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@xxxxxxxxxxxxxxx/T/
> > > 
> > 
> > What is the git commit id of this change?  Is it in Linus's tree yet?
> > And did the original syzbot splat get fixed some other way?
> 
> Revert in mainline is d1aa0c04294e29883d65eac6c2f72fe95cc7c049; patch
> had really been pointless and we'd better watch out for its analogues
> being introduced.
> 
> IMO "fixes a data-race" in patch description has become a serious red flag
> for review by now.  Some of them are valid, some are pointless and occasionally
> actively harmful.
> 

Fair enough, now rejected, thanks for the review!

greg k-h