Re: [PATCH RFC/RFT 4/6] firmware: qcom: scm: Cleanup global '__scm' on probe failures

[Konrad Dybcio]

On 19.11.2024 8:37 PM, Krzysztof Kozlowski wrote:
> On 19/11/2024 19:33, Krzysztof Kozlowski wrote:
>>  	/*
>>  	 * Initialize the QSEECOM interface.
>> @@ -2094,6 +2104,12 @@ static int qcom_scm_probe(struct platform_device *pdev)
>>  	WARN(ret < 0, "failed to initialize qseecom: %d\n", ret);
>>  
>>  	return 0;
>> +
>> +err:
>> +	/* Paired with smp_load_acquire() in qcom_scm_is_available(). */
>> +	smp_store_release(&__scm, 0);
> Heh, I should store there NULL, obviously.

Candidate for a new scoped __free, perhaps?

Konrad