Re: [PATCH v1 2/3] dt-bindings: net: Add QCA6698 Bluetooth

From: Cheng Jiang (IOE)
Date: Thu Nov 28 2024 - 21:14:03 EST


Hi Krzysztof,

On 11/28/2024 10:41 PM, Krzysztof Kozlowski wrote:
> On 28/11/2024 15:41, Krzysztof Kozlowski wrote:
>> On 28/11/2024 13:09, Cheng Jiang wrote:
>>> Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset.
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>>
>> Thank you.
>> </form letter>
>>
>> Respond to the comment and then implement it.
>>
>> Also, version your patches correct and provide changelog. This is v2,
>> not v1.
>
> Wait, no, it's even v3 or v4. You just ask us to the same work twice,
> don't you?
Sorry for this. So the version number should be increased even
solution/implementation is changed? Will follow the rule.
>
> Best regards,
> Krzysztof