Re: [PATCH v2 1/4] dt-bindings: input: touchscreen: Add Z2 controller

From: Krzysztof Kozlowski
Date: Fri Nov 29 2024 - 03:25:25 EST


On 29/11/2024 08:53, Sasha Finkelstein wrote:
> On Fri, 29 Nov 2024 at 08:16, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>> + description:
>>> + Calibration blob supplied by the bootloader
>>
>> What is the expected size? Fixed size or maximum?
>
> Unspecified, 1688 bytes on my machine, but the firmware
> has a size field. Most likely less than 4k.


I suggest putting upper limit. You can still later grow it if different
bootloader uses bigger size.

>
>> Add it to the example.
>
> That seems counterproductive - it is a ~1.5kb blob,
> and it is supposed to be set by the bootloader, not
> by person writing the dts.


Indeed, let's skip it.

Anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof