Re: [PATCH v5 2/3] clk: qcom: common: Add support for power-domain attachment

From: Bryan O'Donoghue
Date: Fri Nov 29 2024 - 07:45:08 EST


On 29/11/2024 11:44, Vladimir Zapolskiy wrote:
On 11/29/24 13:39, Bryan O'Donoghue wrote:
On 29/11/2024 11:30, Vladimir Zapolskiy wrote:
+    ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list);

Please make a call to the function like this:

      ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list);

Passing &pd_data will cause devm_pd_domain_attach_list() to cycle
through the power-domains listed and do dev_pm_domain_attach_by_id();

Doesn't it cycle for pd_data.num_pd_names times? Which is zero.

instead of dv_pm_domain_attach_by_name();

That's what &pd_data is passed here. You want to have that simple
attachment of the power-domain list.

I look at dev_pm_domain_attach_list() function with my best efforts
to concentrate and see no functional difference between your version
and the one proposed by me since v1.

--
Best wishes,
Vladimir

You're right.

I tested again, NULL works. I'll v6.

---
bod