Re: [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support

From: Krzysztof Kozlowski
Date: Fri Nov 29 2024 - 11:05:31 EST


On 29/11/2024 15:25, Ciprian Costea wrote:
> + properties:
> + interrupts:
> + items:
> + - description: Message Buffer interrupt for mailboxes 0-7 and Enhanced RX FIFO
> + - description: Device state change
> + - description: Error detection
> + - description: Message Buffer interrupt for mailboxes 8-127
> + interrupt-names:
> + items:
> + - const: mb-0
> + - const: state
> + - const: berr
> + - const: mb-1
> + required:
> + - compatible
> + - reg


Drop, aren't they already required?

> + - interrupts
> + - interrupt-names
> + else:
> + properties:
> + interrupts:
> + maxItems: 1


Missing constraints for interrupt-names, e.g. :false.


> +
> additionalProperties: false
>
> examples:


Best regards,
Krzysztof