Re: [GIT PULL] tracing: More updates for 6.13

From: Paul Moore
Date: Fri Nov 29 2024 - 18:08:44 EST


On November 29, 2024 8:26:51 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
On Fri, 29 Nov 2024 08:14:56 -0500
Paul Moore <paul@xxxxxxxxxxxxxx> wrote:

The issue appears to be a known GCC bug, though the root cause remains
unclear at this time.

A potential workaround has been proposed, which you can find here:
https://lore.kernel.org/linux-hardening/202410171059.C2C395030@keescook/

However, it seems that the patch has not yet been accepted into the mainline.

I didn't pull that into the audit tree because it isn't a real patch.
Looking at it again on my phone before today's holiday stuff kicks off, I
don't have a problem with the workaround, but i do need to see it as a
proper patch with a commit description, sign off, etc. before I can merge it.

Yeah, from the comment I was expecting to see a proper patch.

So was I :). To be perfectly honest I was really expecting this to get sorted with some compiler flag, workaround, etc. If we have to fix it by hacking around it in the audit code that's okay (the hack looks pretty minor) but it's not still a kludge.


For anyone who is going to put together a patch, please make it clear that
it is a compiler bug and provide the associated bug report links.

If it matters, with that patch applied, all my tests were able to
complete with success.

Tested-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

Thanks.

--
paul-moore.com