Re: [PATCH v2 20/31] arm64: dts: qcom: ipq5018: move board clocks to ipq5018.dtsi file

[Krzysztof Kozlowski]

On 30/11/2024 02:44, Dmitry Baryshkov wrote:
> IPQ5018 is one of the platforms where board-level clocks (XO, sleep)
> definitions are split between the SoC dtsi file and the board file.
> This is not optimal, as the clocks are a part of the SoC + PMICs design.
> Frequencies are common for the whole set of devices using the same SoC.
> Remove the split and move frequencies to the SoC DTSI file.
> 
> Suggested-by: Bjorn Andersson <andersson@xxxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

This contradicts DTS coding style and all my existing review. Obviously
that's a NAK from me. If you want to merge this patch, please kindly
carry my formal objection for this and all following "move board clocks"
patches:

Nacked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

(I'll respond in next patches as well, just for formality/b4)

Best regards,
Krzysztof