Re: [PATCH 13/13] sh/irq: use seq_put_decimal_ull_width() for decimal values

From: John Paul Adrian Glaubitz
Date: Sat Nov 30 2024 - 07:42:08 EST


Hi David,

On Sat, 2024-11-09 at 00:26 +0800, David Wang wrote:
> Performance improvement for reading /proc/interrupts on arch sh
>
> Signed-off-by: David Wang <00107082@xxxxxxx>
> ---
> arch/sh/kernel/irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sh/kernel/irq.c b/arch/sh/kernel/irq.c
> index 4e6835de54cf..9022d8af9d68 100644
> --- a/arch/sh/kernel/irq.c
> +++ b/arch/sh/kernel/irq.c
> @@ -43,9 +43,9 @@ int arch_show_interrupts(struct seq_file *p, int prec)
> {
> int j;
>
> - seq_printf(p, "%*s: ", prec, "NMI");
> + seq_printf(p, "%*s:", prec, "NMI");
> for_each_online_cpu(j)
> - seq_printf(p, "%10u ", per_cpu(irq_stat.__nmi_count, j));
> + seq_put_decimal_ull_width(p, " ", per_cpu(irq_stat.__nmi_count, j), 10);
> seq_printf(p, " Non-maskable interrupts\n");
>
> seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count));

Sorry for the very late reply!

I don't quite understand why seq_put_decimal_ull_width() should be faster than seq_printf().

Can you elaborate on this a bit more?

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913