Re: [PATCH] mux: constify mux class
From: Bartosz Golaszewski
Date: Sat Nov 30 2024 - 10:37:38 EST
On Tue, Nov 5, 2024 at 10:53 PM Peter Rosin <peda@xxxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> 2024-11-01 at 15:21, Bartosz Golaszewski wrote:
> > On Thu, Oct 24, 2024 at 9:08 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >>
> >> On Mon, Oct 14, 2024 at 2:25 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >>>
> >>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >>>
> >>> All class functions used here take a const pointer to the class
> >>> structure so we can make the struct itself constant.
> >>>
> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >>> ---
> >>> drivers/mux/core.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/mux/core.c b/drivers/mux/core.c
> >>> index 78c0022697ec..02be4ba37257 100644
> >>> --- a/drivers/mux/core.c
> >>> +++ b/drivers/mux/core.c
> >>> @@ -42,7 +42,7 @@ struct mux_state {
> >>> unsigned int state;
> >>> };
> >>>
> >>> -static struct class mux_class = {
> >>> +static const struct class mux_class = {
> >>> .name = "mux",
> >>> };
> >>>
> >>> --
> >>> 2.43.0
> >>>
> >>
> >> Gentle ping.
> >>
> >> Bart
> >
> > Peter,
> >
> > Your email doesn't bounce so I assume you are getting this. Any reason
> > why this simple change is not being picked up?
>
> I'm here, and am just being slow as usual. Sorry about that. I have now
> added the patch to linux-next.
>
> Cheers,
> Peter
Peter,
This commit is in next but it's not gone upstream and it's almost the
end of the merge window. I don't see any pending PR from you. Can this
go upstream?
Bartosz