Re: [PATCH 2/7] iio: imu: adis: Add custom ops struct

[Jonathan Cameron]

On Mon, 25 Nov 2024 15:35:09 +0200
Robert Budai <robert.budai@xxxxxxxxxx> wrote:

> This patch introduces a custom ops struct letting users define
> custom read and write functions. Some adis devices might define
> a completely different spi protocol from the one used in the
> default implementation.
> 
> Co-developed-by: Ramona Gradinariu <ramona.gradinariu@xxxxxxxxxx>
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@xxxxxxxxxx>
> Co-developed-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> Signed-off-by: Robert Budai <robert.budai@xxxxxxxxxx>
I assume that by the end of the series, adis_default_ops will be in 
use, but until then I think this change breaks support for all devices
currently supported by not providing a working read / write.

Thanks,

Jonathan

> @@ -488,6 +488,11 @@ int adis_single_conversion(struct iio_dev *indio_dev,
>  }
>  EXPORT_SYMBOL_NS_GPL(adis_single_conversion, IIO_ADISLIB);
>  
> +static const struct adis_ops adis_default_ops = {

Not yet used.  So I'm guessing this patch breaks all existing drivers.

> +	.read = __adis_read_reg,
> +	.write = __adis_write_reg,
> +};