Re: [PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

From: Uwe Kleine-König
Date: Sat Nov 30 2024 - 12:37:46 EST


Hello,

On Mon, Nov 25, 2024 at 05:33:06PM +0800, Liu Ying wrote:
> +struct platform_driver dc_de_driver = {
> + .probe = dc_de_probe,
> + .remove_new = dc_de_remove,

Please use .remove here. Also in a few other patches of this series.

Best regards
Uwe

> + .driver = {
> + .name = "imx8-dc-display-engine",
> + .suppress_bind_attrs = true,
> + .of_match_table = dc_de_dt_ids,
> + .pm = pm_sleep_ptr(&dc_de_pm_ops),
> + },
> +};

Attachment: signature.asc
Description: PGP signature