Re: [PATCH v2 0/3] iio: adc: ad7173: fix non-const info struct

[David Lechner]

On 11/30/24 12:43 PM, Jonathan Cameron wrote:
> On Wed, 27 Nov 2024 14:01:52 -0600
> David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> 
>> While working ad7124, Uwe pointed out a bug in the ad7173 driver.
>> static struct ad_sigma_delta_info ad7173_sigma_delta_info was not const
>> and was being modified during driver probe, which could lead to race
>> conditions if two instances of the driver were probed at the same time.
>>
>> The actual fix part is fairly trivial but I have only compile tested it.
>> Guillaume has access to ad4111 hardware, so it would be good to get a
>> Tested-by from him to make sure this doesn't break anything.
>>
> This is very big for a backport.  So I replied to previous version to suggest
> instead duplicating the data before modifying.  That has much less code
> movement and maybe a cleaner fix.  Perhaps we then cycle back to avoiding
> that copy later.
> 
That is exactly what I did in v2. "iio: adc: ad7173: fix using shared
static info struct" copies the struct before modifying it and is the
only patch with a Fixes: tag.