Re: [PATCH 05/11] iio: imu: kmx61: fix information leak in triggered buffer
From: Jonathan Cameron
Date: Sat Nov 30 2024 - 15:56:38 EST
On Mon, 25 Nov 2024 22:16:13 +0100
Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:
> The 'buffer' local array is used to push data to user space from a
> triggered buffer, but it does not set values for inactive channels, as
> it only uses iio_for_each_active_channel() to assign new values.
>
> Initialize the array to zero before using it to avoid pushing
> uninitialized information to userspace.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: c3a23ecc0901 ("iio: imu: kmx61: Add support for data ready triggers")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Applied.
> ---
> drivers/iio/imu/kmx61.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index 324c38764656..e19c5d3137c6 100644
> --- a/drivers/iio/imu/kmx61.c
> +++ b/drivers/iio/imu/kmx61.c
> @@ -1193,7 +1193,7 @@ static irqreturn_t kmx61_trigger_handler(int irq, void *p)
> struct kmx61_data *data = kmx61_get_data(indio_dev);
> int bit, ret, i = 0;
> u8 base;
> - s16 buffer[8];
> + s16 buffer[8] = { };
>
> if (indio_dev == data->acc_indio_dev)
> base = KMX61_ACC_XOUT_L;
>