Re: [PATCH v2] net/sched: tbf: correct backlog statistic for GSO packets

From: patchwork-bot+netdevbpf
Date: Sat Nov 30 2024 - 16:50:40 EST


Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Mon, 25 Nov 2024 18:46:07 +0100 you wrote:
> When the length of a GSO packet in the tbf qdisc is larger than the burst
> size configured the packet will be segmented by the tbf_segment function.
> Whenever this function is used to enqueue SKBs, the backlog statistic of
> the tbf is not increased correctly. This can lead to underflows of the
> 'backlog' byte-statistic value when these packets are dequeued from tbf.
>
> Reproduce the bug:
> Ensure that the sender machine has GSO enabled. Configured the tbf on
> the outgoing interface of the machine as follows (burstsize = 1 MTU):
> $ tc qdisc add dev <oif> root handle 1: tbf rate 50Mbit burst 1514 latency 50ms
>
> [...]

Here is the summary with links:
- [v2] net/sched: tbf: correct backlog statistic for GSO packets
https://git.kernel.org/netdev/net/c/1596a135e318

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html