Re: [PATCH v2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Guenter Roeck]

On 11/30/24 17:17, Li XingYang wrote:
[ ... ]
> > Please do not send new revisions of a patch as response of an older
> > series, and please always provide a change log.
> Sorry, I cannot fully understand this meaning.
> Should I use the new version of the patch to reply to the old version of
> the patch instead of responding to the questions raised

If you send new revisions of a patch or patch series as reply to older
versions of that patch series, it may get lost because it is not identified
as updated patch but as reply to an older patch or patch series. Also see
"Explicit In-Reply-To headers" in Documentation/process/submitting-patches.rst

[ ... ]
> > This is an unrelated change. It affects other boards of the same family.
> > It needs to be a separate patch, it needs to be explained, and it needs to
> > get some confirmation that it works on the other boards of the same series.
> >
> > Thanks,
> > Guenter
> I found that in the LibreHardwareMonitor project,
> the registers used by Amd600 to operate FanCPUOpt are described:
> https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/blob/master/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/EC/EmbeddedController.cs
> BoardFamily.Amd600, new Dictionary<ECSensor, EmbeddedControllerSource>
> {
> { ECSensor.FanCPUOpt,  new EmbeddedControllerSource("CPU Optional Fan", SensorType.Fan, 0x00b0, 2) },
> }
>
> I think this is suitable for the AMD 600 motherboard, and it does work on my motherboard as well.

That makes sense, but it is still unrelated to this patch and, worse,
not even mentioned in the patch description. See "Separate your changes"
in Documentation/process/submitting-patches.rst.

Guenter