Re: [PATCH v6 2/3] arm64: dts: qcom: move pon reboot-modes from pm8150.dtsi to board files
From: Dmitry Baryshkov
Date: Mon Dec 02 2024 - 05:22:37 EST
On Mon, Dec 02, 2024 at 05:37:23PM +0800, Tingguo Cheng wrote:
> Reboot modes were originally managed by PMIC pon driver on mobile/IoT
> platforms, such as sm8150,sm8250,qdu1000... But recently, QCS615 is
> going to adopt PSCI to manage linux reboot modes, which involves firm
> wares to co-work with. In this case, reboot-modes should be removed
> from pon dts node to avoid conflicting. This implies that reboot modes
> go with devices rather than PMICs as well.
>
> Signed-off-by: Tingguo Cheng <quic_tingguoc@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/pm8150.dtsi | 2 --
> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 5 +++++
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 5 +++++
> arch/arm64/boot/dts/qcom/qru1000-idp.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 5 +++++
> arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 5 +++++
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 5 +++++
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts | 5 +++++
> 13 files changed, 60 insertions(+), 2 deletions(-)
>
Should the qcom-pon.c driver also be modified to skip registration in
such a case? (Can be handled as a separate patch, no need to include it
here / repost the series.)
For the patch itself:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
--
With best wishes
Dmitry