Re: [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support

[Ciprian Marian Costea]

On 11/29/2024 6:05 PM, Krzysztof Kozlowski wrote:
> On 29/11/2024 15:25, Ciprian Costea wrote:
> > +      properties:
> > +        interrupts:
> > +          items:
> > +            - description: Message Buffer interrupt for mailboxes 0-7 and Enhanced RX FIFO
> > +            - description: Device state change
> > +            - description: Error detection
> > +            - description: Message Buffer interrupt for mailboxes 8-127
> > +        interrupt-names:
> > +          items:
> > +            - const: mb-0
> > +            - const: state
> > +            - const: berr
> > +            - const: mb-1
> > +      required:
> > +        - compatible
> > +        - reg
>
>
> Drop, aren't they already required?

Yes, I was not sure if 'required' here overrides or appends the items to 
the 'global' required declaration.
Now I know it appends them, so I will only keep 'interrupt-names'. Thanks.

> > +        - interrupts
> > +        - interrupt-names
> > +    else:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 1
>
>
> Missing constraints for interrupt-names, e.g. :false.

Correct, I will add 'interrupt-names' constraint in V4.

> > +
> >   additionalProperties: false
> >   
> >   examples:
>
>
> Best regards,
> Krzysztof

Best Regards,
Ciprian