Re: [PATCH] staging: gpib: Make GPIB_NI_PCI_ISA depend on HAS_IOPORT

[Geert Uytterhoeven]

On Sat, Nov 23, 2024 at 9:03 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> After commit 78ecb0375685 ("staging: gpib: make port I/O code
> conditional"), building tnt4882.ko on platforms without HAS_IOPORT (such
> as hexagon and s390) fails with:
>
>   ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "outb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>   ERROR: modpost: "outw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
>
> Only allow tnt4882.ko to be built when CONFIG_HAS_IOPORT is set to avoid
> this build failure, as this driver unconditionally needs it.
>
> Fixes: 78ecb0375685 ("staging: gpib: make port I/O code conditional")
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>

Thanks, this fixes my Sun3+allmodconfig build.

Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds