Re: [PATCH 1/2] sched: Optimise task_mm_cid_work duration
From: Gabriele Monaco
Date: Mon Dec 02 2024 - 10:59:55 EST
On Mon, 2024-12-02 at 10:01 -0500, Mathieu Desnoyers wrote:
>
> mm_cpus_allowed can be updated dynamically by setting cpu affinity
> and changing the cpusets. If we change the iteration from each
> possible
> cpus to allowed cpus, then we need to adapt the allowed cpus updates
> with the associated updates to the mm_cid as well. This is adding
> complexity.
>
> I understand that you wish to offload this task_work to a non-
> isolated
> CPU (non-RT). If you do so, do you really care about the duration of
> task_mm_cid_work enough to justify the added complexity to the
> cpu affinity/cpusets updates ?
>
Well, no we don't really care at this point.. If it isn't a quick win
I'd say I can simply remove it from the patchset, for the current use
case it doesn't really matter.
Thanks for the analysis.
Gabriele