Re: [PATCH] vdpa: solidrun: Replace deprecated PCI functions

From: kernel test robot
Date: Mon Dec 02 2024 - 12:18:15 EST


Hi Philipp,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.13-rc1 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/vdpa-solidrun-Replace-deprecated-PCI-functions/20241202-202728
base: linus/master
patch link: https://lore.kernel.org/r/20241202122353.9793-2-pstanner%40redhat.com
patch subject: [PATCH] vdpa: solidrun: Replace deprecated PCI functions
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20241203/202412030150.SVZbOVDL-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412030150.SVZbOVDL-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412030150.SVZbOVDL-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/vdpa/solidrun/snet_main.c: In function 'psnet_open_pf_bar':
>> drivers/vdpa/solidrun/snet_main.c:559:13: warning: unused variable 'ret' [-Wunused-variable]
559 | int ret;
| ^~~


vim +/ret +559 drivers/vdpa/solidrun/snet_main.c

555
556 static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet)
557 {
558 char *name;
> 559 int ret;
560 unsigned short i, bars_found = 0;
561 void __iomem *io;
562
563 name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "psnet[%s]-bars", pci_name(pdev));
564 if (!name)
565 return -ENOMEM;
566
567 /* We don't know which BAR will be used to communicate..
568 * We will map every bar with len > 0.
569 *
570 * Later, we will discover the BAR and unmap all other BARs.
571 */
572 for (i = 0; i < PCI_STD_NUM_BARS; i++) {
573 if (pci_resource_len(pdev, i) == 0)
574 continue;
575
576 io = pcim_iomap_region(pdev, i, name);
577 if (IS_ERR(io)) {
578 SNET_ERR(pdev, "Failed to request and map PCI BARs\n");
579 return PTR_ERR(io);
580 }
581
582 psnet->bars[i] = io;
583 bars_found++;
584 }
585
586 /* No BAR can be used.. */
587 if (bars_found == 0) {
588 SNET_ERR(pdev, "Failed to find a PCI BAR\n");
589 return -ENODEV;
590 }
591
592 return 0;
593 }
594

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki