Re: [PATCH v2] kdb: utilize more readable control characters macro in kdb io

[Doug Anderson]

Hi,

On Thu, Nov 28, 2024 at 12:35 PM Nir Lichtman <nir@xxxxxxxxxxxx> wrote:
>
> Continuing the previous refactor in kdb_keyboard.c of adding the CTRL
> macro, this patch moves the macro to a common header and utilizes this
> pattern in kdb_io.c as well, resulting in more readable code.
>
> I have added the _KEY suffix to make the macro more clear, considering
> it is now common.
>
> Signed-off-by: Nir Lichtman <nir@xxxxxxxxxxxx>
> ---
>
> v2: Refactor another line CTRL+I line I missed in v1 and remove CTRL+K/U
> I accidentaly included in v1.
>
>  kernel/debug/kdb/kdb_io.c       | 38 ++++++++++++++++-----------------
>  kernel/debug/kdb/kdb_keyboard.c | 34 ++++++++++++++---------------
>  kernel/debug/kdb/kdb_private.h  |  2 ++
>  3 files changed, 37 insertions(+), 37 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>