Aw: Re: [PATCH v2 11/18] arm64: dts: mediatek: mt7988: add chosen node on bpi-r4
From: Frank Wunderlich
Date: Mon Dec 02 2024 - 14:52:45 EST
regards Frank
> Gesendet: Montag, 2. Dezember 2024 um 16:58
> Von: "Krzysztof Kozlowski" <krzk@xxxxxxxxxx>
> An: "Frank Wunderlich" <linux@xxxxxxxxx>, "Rob Herring" <robh@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzk+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>
> CC: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Betreff: Re: [PATCH v2 11/18] arm64: dts: mediatek: mt7988: add chosen node on bpi-r4
>
> On 02/12/2024 15:29, Frank Wunderlich wrote:
> > Am 2. Dezember 2024 14:46:24 MEZ schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
> >> On 02/12/2024 13:25, Frank Wunderlich wrote:
> >>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >>>
> >>> Add chosen node on Bananapi R4 board with stdout and default bootargs.
> >>>
> >>> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >>> ---
> >>> arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts | 5 +++++
> >>> 1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
> >>> index 9037f35857a9..1c2a806f6f6c 100644
> >>> --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
> >>> +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
> >>> @@ -9,6 +9,11 @@ / {
> >>> model = "Banana Pi BPI-R4";
> >>> chassis-type = "embedded";
> >>>
> >>> + chosen {
> >>> + stdout-path = &serial0;
> >>> + bootargs = "console=ttyS0,115200n1";
> >>
> >> Drop or merge into stdout path.
> >
> > Have you an example to pass speed setting to stdout-path? As it is only a phandle it is not clear to me how to merge these 2...
> It is really trivial to find, considering that 66% of files have it.
>
> git grep stdout
thanks, wasn't aware that string is here also accepted...found it ("git grep stdout-path" is much better here :) )
will change both lines to this single one:
stdout-path = "serial0:115200n8";
> Best regards,
> Krzysztof
> </frank-w@xxxxxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></krzk@xxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></angelogioacchino.delregno@xxxxxxxxxxxxx></matthias.bgg@xxxxxxxxx></conor+dt@xxxxxxxxxx></krzk+dt@xxxxxxxxxx></robh@xxxxxxxxxx></linux@xxxxxxxxx></krzk@xxxxxxxxxx>