Re: [PATCH v2 09/21] drm/etnaviv: Convert timeouts to secs_to_jiffies()

From: Christian Gmeiner
Date: Mon Dec 02 2024 - 16:17:31 EST


>
> Changes made with the following Coccinelle rules:
>
> @@ constant C; @@
>
> - msecs_to_jiffies(C * 1000)
> + secs_to_jiffies(C)
>
> @@ constant C; @@
>
> - msecs_to_jiffies(C * MSEC_PER_SEC)
> + secs_to_jiffies(C)
>
> Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Christian Gmeiner <cgmeiner@xxxxxxxxxx>

> ---
> drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c b/drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c
> index 721d633aece9d4c81f0019e4c55884f26ee61c60..0f5a2c885d0ab7029c7248e15d6ea3c31823b782 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c
> @@ -100,7 +100,7 @@ int etnaviv_cmdbuf_init(struct etnaviv_cmdbuf_suballoc *suballoc,
> mutex_unlock(&suballoc->lock);
> ret = wait_event_interruptible_timeout(suballoc->free_event,
> suballoc->free_space,
> - msecs_to_jiffies(10 * 1000));
> + secs_to_jiffies(10));
> if (!ret) {
> dev_err(suballoc->dev,
> "Timeout waiting for cmdbuf space\n");
>
> --
> 2.34.1
>


--
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy