Re: [PATCH 0/3] perf tool: Fix multiple memory leakages

[Namhyung Kim]

On Thu, Nov 28, 2024 at 08:54:29PM +0800, Zhongqiu Han wrote:
> Fix memory leakages when btf_node or bpf_prog_info_node is duplicated
> during insertion into perf_env.
> 
> Signed-off-by: Zhongqiu Han <quic_zhonhan@xxxxxxxxxxx>
> ---
> Zhongqiu Han (3):
>   perf header: Fix one memory leakage in process_bpf_btf()
>   perf header: Fix one memory leakage in process_bpf_prog_info()
>   perf bpf: Fix two memory leakages when calling
>     perf_env__insert_bpf_prog_info()

Although I have a nitpick in the patch 3, it looks good otherwise.

Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxxx>

And I don't think the Fixes tags are correct, but it won't apply before
the change it points to.  So for practical reason, I'm ok with that.

Thanks,
Namhyung

> 
>  tools/perf/util/bpf-event.c | 10 ++++++++--
>  tools/perf/util/env.c       | 12 ++++++++----
>  tools/perf/util/env.h       |  4 ++--
>  tools/perf/util/header.c    |  8 ++++++--
>  4 files changed, 24 insertions(+), 10 deletions(-)
> 
> 
> base-commit: f486c8aa16b8172f63bddc70116a0c897a7f3f02
> -- 
> 2.25.1
>