Re: [PATCH] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac_address"

From: Jakub Kicinski
Date: Mon Dec 02 2024 - 18:49:39 EST


On Fri, 29 Nov 2024 17:12:56 +0800 Potin Lai wrote:
> This reverts commit 790071347a0a1a89e618eedcd51c687ea783aeb3.
>
> We are seeing kernel panic when enabling two NCSI interfaces at same
> time. It looks like mutex lock is being used in softirq caused the
> issue.

I agree with Andrew that revert makes sense. On top of his suggestions
please add a correctly formatted Fixes tag and make sure you CC the
authors of the buggy change, and post a v2.
--
pw-bot: cr