Re: [PATCH 5/6] pps: embed "dev" in the pps_device
From: kernel test robot
Date: Mon Dec 02 2024 - 21:04:53 EST
Hi Michal,
kernel test robot noticed the following build errors:
[auto build test ERROR on 7af08b57bcb9ebf78675c50069c54125c0a8b795]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Schmidt/pps-fix-cdev-use-after-free/20241203-025037
base: 7af08b57bcb9ebf78675c50069c54125c0a8b795
patch link: https://lore.kernel.org/r/20241202163451.1442566-6-mschmidt%40redhat.com
patch subject: [PATCH 5/6] pps: embed "dev" in the pps_device
config: i386-buildonly-randconfig-005-20241203 (https://download.01.org/0day-ci/archive/20241203/202412030942.aHisJx3i-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412030942.aHisJx3i-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412030942.aHisJx3i-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/pps/clients/pps-ktimer.c:59:11: error: passing 'struct device' to parameter of incompatible type 'const struct device *'; take the address with &
59 | dev_info(pps->dev, "ktimer PPS source unregistered\n");
| ^~~~~~~~
| &
include/linux/dev_printk.h:160:46: note: expanded from macro 'dev_info'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
include/linux/dev_printk.h:110:11: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:56:37: note: passing argument to parameter 'dev' here
56 | void _dev_info(const struct device *dev, const char *fmt, ...);
| ^
drivers/pps/clients/pps-ktimer.c:77:11: error: passing 'struct device' to parameter of incompatible type 'const struct device *'; take the address with &
77 | dev_info(pps->dev, "ktimer PPS source registered\n");
| ^~~~~~~~
| &
include/linux/dev_printk.h:160:46: note: expanded from macro 'dev_info'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
include/linux/dev_printk.h:110:11: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:56:37: note: passing argument to parameter 'dev' here
56 | void _dev_info(const struct device *dev, const char *fmt, ...);
| ^
2 errors generated.
vim +59 drivers/pps/clients/pps-ktimer.c
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 52
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 53 /*
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 54 * Module staff
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 55 */
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 56
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 57 static void __exit pps_ktimer_exit(void)
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 58 {
5e196d34a77642 Alexander Gordeev 2011-01-12 @59 dev_info(pps->dev, "ktimer PPS source unregistered\n");
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 60
5e196d34a77642 Alexander Gordeev 2011-01-12 61 del_timer_sync(&ktimer);
5e196d34a77642 Alexander Gordeev 2011-01-12 62 pps_unregister_source(pps);
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 63 }
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 64
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki