Re: [PATCH] erofs: fix PSI memstall accounting

From: Max Kellermann
Date: Tue Dec 03 2024 - 03:07:12 EST


On Tue, Dec 3, 2024 at 2:42 AM Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx> wrote:
> I think at least this patch resolves a recent regression,
> I guess we'd better to address it first.

Certainly your patch is an improvement, but maybe this just wasn't the
bug I was experiencing.

> As for your reports, I think we might need more information
> about this, since I don't find more clues from the EROFS
> codebase itself.

What kind of information do you need? I posted some high-level
information about my setup here:
https://lore.kernel.org/lkml/CAKPOu+-_X9cc723v_f_BW4CwfHJe_mi=+cbUBP2tZO-kEcyoMA@xxxxxxxxxxxxxx/
What else do you want to know?
This triggers pretty often now - can we improve Suren's patch to
record and dump more information when this happens?

Right now, we don't even know if this is an erofs problem (and if this
ever was). It is just one of several candidates.

Max