Re: [PATCH v2] i2c: omap: Cleaned up coding style and parameters
From: H. Nikolaus Schaller
Date: Tue Dec 03 2024 - 03:26:25 EST
Just a minor nit:
> Am 03.12.2024 um 08:31 schrieb Dhruv Menon <dhruvmenon1104@xxxxxxxxx>:
>
> Hello Aaro,
>
> I have updated the patch as requiested, splitting it two parts,
>
> 1. [PATCH v2 1/2] i2c: omap: Cleaned up coding style
> 2. [PATCH v2 2/2] i2c: omap: Removed unsed parameter
use "this patch will do" point of view, not "I have done"
=> Cleaned -> Clean
And there is a typo in "unsed".
>
> I have also removed the changes regarding msleep as the adjustment
> was relatively minor. The change was initially considered based
> on "Timer's howto" documentation which recommends to change any
> msleep(x) < 10ms to usleep_range(x*1000, x*2000) for better
> precision.
>
> Thank you for the time and review. I look forward to your feedback
>
> Regards
> Dhruv Menon
>